13 Aug
2024
13 Aug
'24
6:02 p.m.
Jacek Caban (@jacek) commented about dlls/mshtml/mutation.c:
if(!wcsicmp(http_equiv, L"x-ua-compatible")) { compat_mode_t document_mode; - if(parse_ua_compatible(content, &document_mode)) - set_document_mode(doc, document_mode, TRUE); + BOOL emulate_mode = parse_ua_compatible(content, &document_mode); + if(document_mode != COMPAT_MODE_INVALID)
`document_mode` will be uninitialized if `parse_ua_compatible` uses early return. Using return value for emulation mode looks weird here, I'd suggest to swap those and return document mode instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6260#note_78565