24 Nov
2022
24 Nov
'22
11 a.m.
Georg Lehmann (@DadSchoorse) commented about dlls/winevulkan/vulkan_thunks.c:
FIXME("Unexpected pNext\n"); }
+#ifdef _WIN64 +static inline void convert_VkSparseMemoryBind_win64_to_host(const VkSparseMemoryBind *in, VkSparseMemoryBind *out) +{ + if (!in) return; + + out->resourceOffset = in->resourceOffset; + out->size = in->size; + out->memory = wine_device_memory_from_handle(in->memory)->memory;
This is broken because memory can be `VK_NULL_HANDLE`. Proton had a similar bug: https://github.com/ValveSoftware/wine/pull/148 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1502#note_17320