26 Jul
2023
26 Jul
'23
2 p.m.
On Wed Jul 26 12:39:41 2023 +0000, Giovanni Mascellani wrote:
Hhm, from the comment it seems that `idx` should always be contained in 32 bit, but the code apparently allows it to be bigger, provided that it's larger than `UINT64_MAX - INT32_MAX`. What's the actual intent? The LLVM source casts it to an `unsigned int` without any further checking, so I think a warning if it's `> 0xffffffff` will suffice.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283#note_40324