Re: [PATCH v2 0/4] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/msi/tests/db.c:
> r = MsiViewFetch(hview, &hrec);
>      ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r);
> -    check_record(hrec, 2, "1", "one");
> +    sz = sizeof(str);
> +    MsiRecordGetStringA(hrec, 2, str, &sz);
> +    ok(!strcmp(str, "one") || broken(!*str), "Expected \"one\", got \"%s\"\n", str);

Tests should pass on some version of Windows (ideally the latest), so if you have to add broken() to make them pass at all there's something wrong with the tests.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10114#note_129785