Re: [PATCH 0/1] MR1701: wshom.ocx: Implement IWshNetwork2_get_UserName().

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/wshom.ocx/tests/wshom.c:
> check_interface(disp, &IID_IObjectWithSite, FALSE);
>
> IDispatch_Release(disp);
> +
> +    hr = CoCreateInstance(&CLSID_WshNetwork, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER,
> +            &IID_IDispatch, (void**)&nw2);
> +
> +    str = NULL;
> +    hr = IWshNetwork2_get_UserName(nw2, &str);
> +    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> +    ok(str && str[0] != 0, "got empty string\n");
> +    CHECK_BSTR_LENGTH(str);
> +    SysFreeString(str);
> +
> +    IWshNetwork2_Release(nw2);

Why not reuse previously created object? Also, could you compare the value against GetUserName() result? That way we know we return consistent value.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1701#note_18952