17 Jan
2024
17 Jan
'24
5:08 p.m.
On Wed Jan 17 08:16:29 2024 +0000, Rémi Bernon wrote:
There was a lot of struct sharing like that before, I don't think it's a good idea for refactorability. Exposing a few helper functions and manipulating object through their COM interface pointers instead provides better isolation between components. I considered it when I wrote this, however:
AudioPathConfig doesn't have any COM interfaces defined for it though (besides IDirectMusicObject). Should I add a wine private interface? Other thing is adding getters is annoying especially when there are linked lists involved. And I feel doing all this for purely internal types doesn't really add much value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4852#note_57728