Re: [PATCH v2 0/1] MR3974: winemac.drv: Ensure user-land callback can access app_icon results.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/winemac.drv/dllmain.c:
> int i;
>
> TRACE("()\n");
>
> -    result->count = 0;
> +    if (size)
> +        return NtCallbackReturn(NULL, 0, STATUS_INVALID_PARAMETER);
>
> +    result.count = 0;
>      res_info = NULL;
>      EnumResourceNamesW(NULL, (LPCWSTR)RT_GROUP_ICON, get_first_resource, (LONG_PTR)&res_info);
>      if (!res_info)
>      {
>          WARN("found no RT_GROUP_ICON resource\n");
> -        return 0;
> +        goto cleanup;

This change is not needed, Unix side may deduce that from 0 result size. In fact, I'd be tempted to get rid of `app_icon_result`, pass an array of `app_icon_entry`, use the size of actually used entries and calculate count from that size on Unix side.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3974#note_47105