4 Feb
2025
4 Feb
'25
9:59 p.m.
Esme Povirk (@madewokherd) commented about dlls/windowscodecs/regsvr.c:
+ if (res != ERROR_SUCCESS) + RegCloseKey(coclass_key); + } + if (res != ERROR_SUCCESS) goto error_return; + + for (; res == ERROR_SUCCESS && list->clsid; ++list) + { + HKEY clsid_key; + HKEY instance_clsid_key; + + StringFromGUID2(list->clsid, buf, 39); + res = RegCreateKeyExW(coclass_key, buf, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &clsid_key, NULL); + if (res != ERROR_SUCCESS) goto error_close_coclass_key; + + StringFromGUID2(list->clsid, buf, 39); I don't think we need to convert this twice?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7254#note_93631