3 Jan
2024
3 Jan
'24
5:13 p.m.
Rémi Bernon (@rbernon) commented about programs/winedbg/gdbproxy.c:
} if (FD_ISSET( gdbctx.sock, &read_fds )) { - if (fetch_data(&gdbctx) > 0) - { - if (extract_packets(&gdbctx)) break; - } + if (fetch_data(&gdbctx) == 0) /* connection closed */ + break; + extract_packets(&gdbctx);
The `extract_packets` return value is now ignored, it should either be made void, or used to break the loop too (I think the latter is better). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4776#note_56619