21 Nov
2022
21 Nov
'22
1:21 p.m.
Jacek Caban (@jacek) commented about dlls/ieframe/navigate.c:
WCHAR *new_url;
if(url) { - new_url = heap_strdupW(url); + new_url = wcsdup(url); if(!new_url) return E_OUTOFMEMORY; }else { new_url = NULL; }
- heap_free(This->url); + free(This->url);
This does not match `DocHost_Release`. It's not the first such case, the way you selectively convert allocations is both more error-prone and harder to review than needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1461#note_16689