15 Apr
2025
15 Apr
'25
8:55 a.m.
Nikolay Sivov (@nsivov) commented about dlls/winegstreamer/video_processor.c:
if (FAILED(hr = IMFTransform_GetOutputStreamInfo(iface, 0, &info))) return hr;
- if (impl->output_info.dwFlags & MFT_OUTPUT_STREAM_PROVIDES_SAMPLES) + if (FAILED(IMFAttributes_GetUINT32(impl->attributes, &MF_XVP_PLAYBACK_MODE, (UINT32 *) &use_caller_samples))) + use_caller_samples = FALSE; + + use_caller_samples = use_caller_samples || !(impl->output_info.dwFlags & MFT_OUTPUT_STREAM_PROVIDES_SAMPLES); + + if (!use_caller_samples)
I would rather use non-negated condition, like "if (provides_samples)", but it's not important. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796#note_100908