31 Jan
2024
31 Jan
'24
12:16 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-utils/reflection.c:
static struct ID3D12ShaderReflectionConstantBuffer * STDMETHODCALLTYPE d3d12_reflection_GetConstantBufferByIndex( ID3D12ShaderReflection *iface, UINT index) { - FIXME("iface %p, index %u stub!\n", iface, index); + struct d3d12_reflection *reflection = impl_from_ID3D12ShaderReflection(iface);
- return NULL; + TRACE("iface %p, index %u.\n", iface, index); + + if (index > reflection->buffer_info.buffer_count) Shouldn't this be `>=`?
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/606#note_59608