31 Oct
2022
31 Oct
'22
2:36 p.m.
On Mon Oct 31 11:16:43 2022 +0000, Piotr Caban wrote:
The patch looks OK but commit message might be improved. I don't know what crash do you have in mind (is it even possible to see it without modifying wine source?). How about changing it to `msvcp90: Make _Condition_variable_* function pointers static.`? _Condition_variable_notify_one and DEFINE_THISCALL_WRAPPER(_Condition_variable_notify_one, 4) are redefined in other dynamic libraries. Therefore, it caused the problem of global symbol coverage, which caused crash.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1187#note_12515