24 Apr
2023
24 Apr
'23
10:49 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d/vkd3d_private.h:
struct d3d12_descriptor_heap_vk_set vk_descriptor_sets[VKD3D_SET_INDEX_COUNT]; struct vkd3d_mutex vk_sets_mutex;
- BYTE descriptors[]; + BYTE DECLSPEC_ALIGN(8) descriptors[];
Why not `DECLSPEC_ALIGN(sizeof(void*))`, so that we avoid a magic number? Also, the commit message says "pointer aligned", but depending on the architecture 8 is more than a pointer. What is the actual requirement? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/156#note_30992