17 Nov
2025
17 Nov
'25
4:06 a.m.
Let's not make changes to both v5 and v6 at the same time. It would be easier for review if you could split them.
In fact, although I use `#if __WINE_COMCTL32_VERSION == 5` here, it only changes v6. For v6 I added code that premultiply alpha channel in `add_dib_bits`, so we need to remove this line for v6. To keep it the same as before for v5, I added a v5 guard.
Also, try to avoid the \__WINE_COMCTL32_VERSION checks in the middle of the function. See if you could move them into a helper.
OK, I'll try to move them to helpers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9348#note_122483