Re: [PATCH 0/1] MR4539: d3dx9_36: Use CRT allocation functions.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/effect.c:
> -        if (!pool->shared_data[i].size)
> -        {
> -            new_size = INITIAL_SHARED_DATA_SIZE;
> -            pool->shared_data[i].parameters = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> -                    sizeof(*pool->shared_data[i].parameters) * INITIAL_SHARED_DATA_SIZE);
> -        }
> -        else
> -        {
> -            new_size = pool->shared_data[i].size * 2;
> -            pool->shared_data[i].parameters = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> -                    pool->shared_data[i].parameters,
> -                    sizeof(*pool->shared_data[i].parameters) * new_size);
> -        }
> +        struct d3dx_top_level_parameter **new_alloc;
> +
> +        new_size = pool->shared_data[i].size ? pool->shared_data[i].size * 2 :INITIAL_SHARED_DATA_SIZE;
> Nitpick: whitespace.

Thanks for adding the error check here.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4539#note_54557