Re: [PATCH v3 0/8] MR5362: mfplat: Test and implement various audio media type conversions.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfplat/mediatype.c:
> +    HRESULT hr;
> +
> +    if (FAILED(hr = MFCreateMediaType(media_type)))
> +        return hr;
> +
> +    if (IsEqualGUID(&guid_representation, &AM_MEDIA_TYPE_REPRESENTATION))
> +        hr = MFInitMediaTypeFromAMMediaType(*media_type, representation);
> +
> +    if (FAILED(hr))
> +    {
> +        IMFMediaType_Release(*media_type);
> +        *media_type = NULL;
> +    }
> +
> +    return hr;
> +}
> Let's add a fixme for unrecognized representation guids. A simple test would be helpful too, maybe we should simply fail, and that will remove some branching as well.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5362#note_65534