13 Apr
2023
13 Apr
'23
10:55 p.m.
On Thu Apr 13 22:37:18 2023 +0000, Zebediah Figura wrote:
on other attributes, we should `hlsl_fixme()`, because (AFAIU) there is at least an attribute that could change the semantics if ignored (e.g., `allow_uav_condition`). We could `hlsl_warning()` for the attributes we already consider relatively safe to ignore. Yes, I agree with this part. v4 had it as hlsl_fixme(). In general I think we should put in the effort to avoid ever emitting invalid bytecode. Okay, I restored hlsl_fixme() for known documented attributes, and a warning is for the rest.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150#note_29990