Re: [PATCH 0/1] MR10230: combase: Add RoFailFastWithErrorContext stub

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/combase/roapi.c:
> return REGDB_E_CLASSNOTREG;
>  }
> +
> +/***********************************************************************
> + *      RoGetErrorReportingFlags (combase.@)
> + */
> +void WINAPI RoFailFastWithErrorContext(HRESULT hr)
> +{
> +    FIXME("(0x%08lx)\n", hr);

Anything named FailFast being able to return makes me nervous. I'd rather see an abort() or TerminateProcess(self, 1) or something after the fixme.

But I'm not entirely sure what Wine's stub policy is. If it says something contrary, ignore me.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10230#note_131034