Re: [PATCH v5 0/6] MR1628: ntdll: Implement Low Fragmentation Heap.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about dlls/ntdll/heap.c:
> +    {
> +    case HeapCompatibilityInformation:
> +    {
> +        ULONG compat_info;
> +
> +        if (size < sizeof(ULONG)) return STATUS_BUFFER_TOO_SMALL;
> +        if (!(heap = unsafe_heap_from_handle( handle, 0, &flags ))) return STATUS_INVALID_HANDLE;
> +        if (heap->flags & HEAP_NO_SERIALIZE) return STATUS_SUCCESS;
> +
> +        compat_info = *(ULONG *)info;
> +        if (compat_info != HEAP_STD && compat_info != HEAP_LFH)
> +        {
> +            FIXME( "HeapCompatibilityInformation %lu not implemented!\n", compat_info );
> +            return STATUS_UNSUCCESSFUL;
> +        }
> +        if (InterlockedCompareExchange( &heap->compat_info, compat_info, HEAP_STD )) return STATUS_UNSUCCESSFUL;
> How about this?
        if (InterlockedCompareExchange( &heap->compat_info, compat_info, HEAP_STD ) != HEAP_STD)
        {
            return STATUS_UNSUCCESSFUL;
        }

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1628#note_22819