21 Sep
2023
21 Sep
'23
5:19 a.m.
On Thu Sep 21 05:19:42 2023 +0000, Jeffrey Smith wrote:
At each commit along the patch set, all tests need to run clean. Anything that fails on Wine should be marked as such with `todo_wine` or `todo_wine_if` as appropriate. So you would start with commit(s) adding tests, generally including (marked) failing tests. Then any commit that changes/fixes a test result should adjust/remove the todo markers in the same commit. Ah okay, that would have been great to know before I removed all the todo's lol. This is going to be a mess to cleanup, got any tips?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46133