Re: [PATCH v14 0/9] MR6621: winebth.sys part 1: Introduce Bluetooth driver.

[Elizabeth Figura (＠zfigura)]

Elizabeth Figura (@zfigura) commented about dlls/winebth.sys/unixlib.c:
> +static NTSTATUS get_unique_name( const struct unix_name *name, char *buf, SIZE_T *buf_size )
> +{
> +    SIZE_T path_len, i;
> +
> +    path_len = strlen( name->str );
> +    if (*buf_size <= (path_len * sizeof(char)))
> +    {
> +        *buf_size = ( path_len + 1 ) * sizeof(char);
> +        return STATUS_BUFFER_TOO_SMALL;
> +    }
> +
> +    for (i = 0; i < path_len; i++)
> +    {
> +        if (name->str[i] == '/') buf[i] = '_';
> +        else
> +            buf[i] = isalpha( name->str[i] ) ? toupper( name->str[i] ) : name->str[i];
> I don't think you need that isalpha()?

What's the point of the toupper() anyway?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6621#note_85272