Re: [PATCH v2 0/3] MR8612: ntdll: Return STATUS_INVALID_ADDRESS for free regions in get_memory_region_info().

[Dmitry Timoshkov (＠dmitry)]

Dmitry Timoshkov (@dmitry) commented about dlls/ntdll/unix/virtual.c:
> return STATUS_NOT_IMPLEMENTED;
>      }
>
> -    if ((status = fill_basic_memory_info( addr, &basic_info ))) return status;
> +    if ((status = fill_basic_memory_info( addr, &basic_info, &view_size ))) return status;
> +    if (basic_info.State == MEM_FREE) return STATUS_INVALID_ADDRESS;
>
> info->AllocationBase = basic_info.AllocationBase;
>      info->AllocationProtect = basic_info.AllocationProtect;
>      info->RegionType = 0; /* FIXME */
>      if (len >= FIELD_OFFSET(MEMORY_REGION_INFORMATION, CommitSize))
> -        info->RegionSize = basic_info.RegionSize;
> +        info->RegionSize = view_size;

Wouldn't it be more natural to use SIZE_T for view_size since info-\>RegionSize has this type?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8612#note_110543