10 Nov
2022
10 Nov
'22
10:39 p.m.
Francisco Casas (@fcasas) commented about libs/vkd3d-shader/hlsl.y:
FIXME("Unhandled type %s.\n", hlsl_node_type_to_string(node->type)); return 0;
+ case HLSL_IR_CALL: case HLSL_IR_IF: case HLSL_IR_JUMP: case HLSL_IR_LOOP: case HLSL_IR_RESOURCE_STORE: case HLSL_IR_STORE: - WARN("Invalid node type %s.\n", hlsl_node_type_to_string(node->type)); + assert(0);
Maybe this could be updated to `vkd3d_unreachable();`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/47#note_13995