Re: [PATCH v9 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK

[Sven Baars (＠sbaars)]

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c:
> +        ERR("SetIDList failed\n");
> +        IShellLinkW_Release(shelllink);
> +        return hr;
> +    }
> +
> +    if (!_ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH))
> +    {
> +        ERR("Failed to get Path Text\n");
> +        IShellLinkW_Release(shelllink);
> +        return E_FAIL;
> +    }
> +
> +    if (!SHGetPathFromIDListW(This->pidl, root))
> +    {
> +        /* Special PIDL, use the desktop */
> +        if (FAILED(SHGetFolderPathW(NULL, CSIDL_DESKTOP, NULL, 0, root))) {
> This could use a test.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_122749