Re: [PATCH v2 0/5] MR2422: win32u: Implement NtUserBuildHimcList syscall.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/win32u/window.c:
> return ptr;
>  }
>
> +/***********************************************************************
> + *           next_user_handle_ptr
> + */
> +void *next_user_handle_ptr( HANDLE *handle, unsigned int type )
> +{
> +    struct user_object *ptr;
> +    WORD index = *handle ? USER_HANDLE_TO_INDEX( *handle ) + 1 : 0;
> +
> +    user_lock();

Callers need to lock themselves to be able to use this helper properly anyway. Additional locking here is not needed and I think it makes the caller look a bit more questionable with the additional release.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2422#note_27173