Re: [PATCH 0/1] MR1562: wininet: Simplify memory allocation in HTTP_InsertCustomHeader.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/wininet/http.c:
> TRACE("--> %s: %s\n", debugstr_w(lpHdr->lpszField), debugstr_w(lpHdr->lpszValue));
>      count = request->nCustHeaders + 1;
> -    if (count > 1)
> -    {
> -        lph = realloc(request->custHeaders, sizeof(HTTPHEADERW) * count);
> -        memset(lph + request->nCustHeaders, 0, sizeof(HTTPHEADERW));
> -    }
> -    else
> -    {
> -        lph = calloc(count, sizeof(HTTPHEADERW));
> -    }
> +    lph = realloc(request->custHeaders, sizeof(HTTPHEADERW) * count);
> +    memset(lph + request->nCustHeaders, 0, sizeof(HTTPHEADERW));

This `memset()` is redundant (it also broke OOM handling in db691cd9d0a49).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1562#note_17642