28 Oct
2025
28 Oct
'25
2:31 p.m.
Jinoh Kang (@iamahuman) commented about dlls/combase/tests/roapi.c:
winetest_pop_context(); } } + + /* Tests specific to delayed marshaling */ + for (from_type = RO_INIT_SINGLETHREADED; from_type <= RO_INIT_MULTITHREADED; from_type++) + { + winetest_push_context("from_type=%d", from_type); + RoInitialize(from_type);
Anything mutating global state that persist across test functions should be error checked IMO. If initialization fails for some reason, further RoUninitialize() will be unbalanced, leading to subtle bugs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9299#note_119873