On Thu Sep 12 13:09:48 2024 +0000, Jacek Caban wrote:
I think it would make sense to abstract thread data handling details from places like this or event handler. This could look like: ``` block_task_processing(); This->proc(...); unblock_task_processing(); ``` Maybe we could even use the same helpers in `hidden_proc` itself. I went with a way to return thread_data, mostly so I can deal with failure. If you think it's not important I can change it to your suggestion.
Also I kept the `hidden_proc` same as before since it's already "internal" to it and we only unblock timers, because we're already in WM_PROCESSTASK, no need to post a message (which would happen on almost every task, most by far won't be nested). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6375#note_82025