16 Aug
2023
16 Aug
'23
2:20 p.m.
Piotr Caban (@piotr) commented about dlls/msvcrt/tests/file.c:
CreateProcessA(NULL, cmdline, NULL, NULL, TRUE, CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, NULL, NULL, &startup, &proc); wait_child_process(proc.hProcess); + CloseHandle(proc.hProcess); + CloseHandle(proc.hThread); + + sprintf(cmdline, "%s file stdin /freopen", selfname); + CreateProcessA(NULL, cmdline, NULL, NULL, TRUE, + CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS, NULL, NULL, &startup, &proc);
Is there any reason to run the test in new process? We already have tests that modify _file FILE member value (see test_fflush). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3578#note_42486