30 Aug
2022
30 Aug
'22
10:10 a.m.
On Tue Aug 30 09:36:33 2022 +0000, Jacek Caban wrote:
Yeah, it seems that pulse_cond_wait return value handling is reversed. I think that 6f632affa75a meant to handle it similarly to equivalent pulse_test_connect. Even then one would typically check the predicate first, e.g. something like:
while ((state = pa_context_get_state(pulse_ctx) != PA_CONTEXT_READY) &&
state != PA_CONTEXT_FAILED && state != PA_CONTEXT_TERMINATED)
pulse_cond_wait();
if (state != PA_CONTEXT_READY) goto fail;
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/723#note_7212