20 Feb
2023
20 Feb
'23
7:51 p.m.
On Mon Feb 20 15:46:06 2023 +0000, Giovanni Mascellani wrote:
Is there a reason for calling this twice? Can't the first computation be cached? This function is called both in `write_sm4_rdef()` and `write_sm4_shdr()` so, we would require to store the result somewhere outside these functions, the alternatives I see are a static variable, the `ctx`, and a local variable in `hlsl_sm4_write()` and passing it as a parameter. I don't think that these options are very clean.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/66#note_24839