Re: [PATCH 0/4] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/ntdll/unix/file.c:
> }
>          SERVER_END_REQ;
> +        if (status != STATUS_BUFFER_OVERFLOW)
> +            break;
> +    }
> +
> +    if (handles_size)
> +    {
> +        for (i = 0; i < handles_size / sizeof(*cancelled_handles); ++i)
> +        {
> +            select_op.wait.op = SELECT_WAIT;
> +            select_op.wait.handles[0] = cancelled_handles[i];
> +
> +            server_select( &select_op, offsetof(union select_op, wait.handles[1]),
> +                           SELECT_INTERRUPTIBLE, TIMEOUT_INFINITE, NULL, NULL );
> +        }

Any reason not to use SELECT_WAIT_ALL instead of a loop?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7797#note_100761