Re: [PATCH 0/3] MR341: vkd3d-shader/hlsl: Add constant folding for 'fract'.

[Francisco Casas (＠fcasas)]

Francisco Casas (@fcasas) commented about libs/vkd3d-shader/hlsl_constant_ops.c:
> +    enum hlsl_base_type type = dst_type->base_type;
> +    unsigned int k;
> +
> +    assert(type == src->node.data_type->base_type);
> +
> +    for (k = 0; k < dst_type->dimx; ++k)
> +    {
> +        switch (type)
> +        {
> +            case HLSL_TYPE_FLOAT:
> +            case HLSL_TYPE_HALF:
> +                dst->u[k].f = exp2f(src->value.u[k].f);
> +                break;
> +
> +            default:
> +                FIXME("Fold 'fract' for type %s.\n", debug_hlsl_type(ctx, dst_type));
> It should be 'exp2' here.

Btw I see we are not being very consistent with the format of the FIXME's across the different folding functions.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/341#note_45103