Re: [PATCH 0/1] MR1701: wshom.ocx: Implement IWshNetwork2_get_UserName().

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/wshom.ocx/network.c:
> +    DWORD len = 0;
>
> -    return E_NOTIMPL;
> +    TRACE("%p\n", user_name);
> +
> +    GetUserNameW(NULL, &len);
> +    *user_name = SysAllocStringLen(NULL, len-1);
> +    if (!*user_name)
> +        return E_OUTOFMEMORY;
> +
> +    ret = GetUserNameW(*user_name, &len);
> +    if (!ret) {
> +        SysFreeString(*user_name);
> +        *user_name = NULL;
> +        return HRESULT_FROM_WIN32(GetLastError());
> +    }
> It's better to not have any additional calls between failed function GetLastError().

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1701#note_18953