Re: [PATCH v6 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/gdiplus/image.c:
> +/*****************************************************************************
> + * GdipGetEffectParameters [GDIPLUS.@]
> + */
> +GpStatus WINGDIPAPI GdipGetEffectParameters(CGpEffect *effect,
> +    UINT *size, VOID *params)
> +{
> +    GpEffect *ef;
> +
> +    TRACE("(%p,%p,%p)\n", effect, size, params);
> +    if (!effect || !params || !size)
> +        return InvalidParameter;
> +
> +    ef = (GpEffect *)effect;
> +    *size = ef->paramsize;
> +    params = ef->params;

This just changes the pointer stored locally in the function's `params` variable, which isn't used afterwards, so it doesn't actually do anything.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_55734