On Fri Feb 27 16:47:13 2026 +0000, Piotr Caban wrote:
It's currently the longest line in the file - could you please split it? Thinking about it more, maybe following code is easier to understand: ```c if(!(file->_flag & (MSVCRT__NOBUF | _IOMYBUF | MSVCRT__USERBUF))) msvcrt_alloc_buffer(file); bufsize = file->_bufsiz > 0 ? file->_bufsiz : 1; ``` What do you think? This changes the logic, in the absence of alloc_buffer call it relies on file->bufsiz ignoring flags. That’s probably fine but given the interest of some apps in fiddling with file structs directly I personally don’t see such a difference as no-op. Maybe I will just split ternary expression with ‘if’ (I also think too complicated ternary expressions are less readable) but keep flag checks?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10199#note_130743