On Thu Jan 29 11:17:35 2026 +0000, Nikolay Sivov wrote:
I closed this MR because I adjusted the formatting and submitted a new MR (with identical content) at: You don't need to do that, just do git push --force to the same branch, and it will update existing MR. This is better, because it preserves comments in one place. I am handling the VT_EMPTY type here because the program I migrated (WPS PDF Editor) passed this type as v_show, which resulted in the same behavior as when I set this parameter to 'EMPTY' via a VB script: the main window of the program failed to display. However, on the Windows platform, programs that provide this parameter can display the window normally. This is different from omitted optional argument, if you pass special Empty value in the script, it will be represented as VT_EMPTY, regardless of argument being optional. Previously, I did not notice the logic of `is_optional_argument`. Should this function treat VT_EMPTY as a case where an optional argument is not specified, in order to maintain consistent behavior with the Windows platform? I don't think so. For now it's fine to do that per-method. Thank you for pointing out these issues. Should I now update the commit message and description to reflect the compatibility handling for the VT_EMPTY parameter and proceed to merge it, or should I leave the function as it is?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9997#note_128367