17 May
2023
17 May
'23
8:58 p.m.
On Wed May 17 16:34:48 2023 +0000, Zebediah Figura wrote:
Um... yeah, that was my intent. That the tests pass anyway is concerning, though, and suggests that at least we don't have enough. I'll take a closer look. The tests don't test the implicit swapchain because it's never actually exposed, and only exists I think because of some wined3d reasons probably related to GL.
Not only is the comment about swapchain references incorrect since b15685355c, but currently there's not even any reason to create a dxgi swapchain for the wined3d implicit swapchain, so I've replaced patch 2/4 with a patch that removes that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2822#note_33053