24 May
2023
24 May
'23
6:19 p.m.
Zebediah Figura (@zfigura) commented about dlls/winegstreamer/unixlib.c:
for (tmp = transforms; tmp != NULL && element == NULL; tmp = tmp->next) { name = gst_plugin_feature_get_name(GST_PLUGIN_FEATURE(tmp->data)); + + if (!strcmp(name, "vaapidecodebin")) + { + /* vaapidecodebin adds too much abstraction and wg_transform works best with lower-level elements. */
There may be a good reason to blacklist vaapidecodebin, but I don't think this is specific enough. What about vaapidecodebin is "too much abstraction"? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2893#note_33725