Re: [PATCH v4 0/9] MR148: vkd3d-shader/hlsl: Support semantics for array types.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl_codegen.c:
> if (!(name = hlsl_get_string_buffer(ctx)))
>          return NULL;
>      vkd3d_string_buffer_printf(name, "<%s-%s%u>", output ? "output" : "input", semantic->name, index);
> +
> +    LIST_FOR_EACH_ENTRY(ext_var, &ctx->extern_vars, struct hlsl_ir_var, extern_entry)
> +    {
> +        if (!ascii_strcasecmp(ext_var->name, name->buffer))
> +        {
> +            hlsl_release_string_buffer(ctx, name);
> +            return ext_var;
> +        }
> +    }
> +

I'm inclined to say we should merge this commit in with the previous one, to avoid the temporary incorrect code.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148#note_30015