26 Sep
2024
26 Sep
'24
7:53 a.m.
On Thu Sep 26 07:15:22 2024 +0000, Alexandros Frantzis wrote:
One fix is to add `if (!surface->xdg_toplevel) return;` at the beginning of `wayland_surface_update_state_toplevel()`. It depends on what we want `surface->role` to mean. If it is "possible role" (which seems to match how other parts of the code are implemented) then this should be OK. Alternatively, perhaps a more explicit arrangement `surface->role` vs `surface->possible_role` would make things clearer? Thanks for catching this! The if was there originally, I added it back.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6560#note_83415