Re: [PATCH v2 0/3] MR4243: rtworkq: free cancelled work items

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/rtworkq/queue.c:
> {
>          list_remove(&item->entry);
>          item->key = 0;
> -        IUnknown_Release(&item->IUnknown_iface);
>      }
>      LeaveCriticalSection(&item->queue->cs);
> +    IUnknown_Release(&item->IUnknown_iface);

This releases &item->IUnknown_iface even though item->key is NULL, which is a behavior. Are you sure this is correct?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_50486