Re: [PATCH v5 0/3] MR8761: mshtml: Fire BeforeNavigate2 for documents in async_open.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/nsio.c:
> -        HRESULT hres;
> -        BSTR uri_str;
> -
> -        hres = IUri_GetDisplayUri(This->uri->uri, &uri_str);
> -        if(SUCCEEDED(hres)) {
> -            TRACE("opening %s\n", debugstr_w(uri_str));
> -            SysFreeString(uri_str);
> -        }else {
> -            WARN("GetDisplayUri failed: %08lx\n", hres);
> -        }
> -    }
> +    hres = IUri_GetDisplayUri(This->uri->uri, &uri_str);
> +    if(SUCCEEDED(hres) && TRACE_ON(mshtml))
> +        TRACE("opening %s\n", debugstr_w(uri_str));
> +    else if (FAILED(hres))
> +        WARN("GetDisplayUri failed: %08lx\n", hres);
> We don’t need it in most cases, so let’s query it only when necessary in the new branch that you add.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8761#note_112933