Re: [PATCH v8 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.

[Paul Gofman (＠gofman)]

Paul Gofman (@gofman) commented about dlls/ntdll/unix/sync.c:
> */
>  NTSTATUS WINAPI NtDelayExecution( BOOLEAN alertable, const LARGE_INTEGER *timeout )
>  {
> +    NTSTATUS yield_result = STATUS_SUCCESS;
> +
>      /* if alertable, we need to query the server */
> -    if (alertable) return server_wait( NULL, 0, SELECT_INTERRUPTIBLE | SELECT_ALERTABLE, timeout );
> +    if (alertable)
> +    {
> +        /* Since server_wait will result in an unconditional implicit yield,
> +           we never return STATUS_NO_YIELD_PERFORMED */
> +        if (server_wait( NULL, 0, SELECT_INTERRUPTIBLE | SELECT_ALERTABLE, timeout ) == STATUS_USER_APC)
> probably clearer the other way around:
if ((status = server_wait( ... )) == STATUS_TIMEOUT) status = STATUS_SUCCESS;
return status;

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7169#note_92933