24 Feb
2025
24 Feb
'25
1:48 p.m.
Connor McAdams (@cmcadams) commented about dlls/comctl32/syslink.c:
static HRESULT WINAPI Accessible_get_accName(IAccessible *iface, VARIANT childid, BSTR *name) { - FIXME("%p\n", iface); - return E_NOTIMPL; + SYSLINK_ACC *This = impl_from_IAccessible(iface); + HRESULT hr; + DOC_ITEM* item; + BSTR result; + + TRACE("%p, %s\n", iface, debugstr_variant(&childid)); +
Adding a `NULL` check for name and clearing it to `NULL` in case of failure would probably be useful here to avoid potentially returning an uninitialized variable upon failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7402#note_95726