Rémi Bernon (@rbernon) commented about dlls/dmime/segment.c:
+} + +static HRESULT parse_midi(struct segment *This, IStream *stream) +{ + LARGE_INTEGER offset; + DWORD length; + ULONG i; + HRESULT hr; + WORD format, number_of_tracks, division; + + /* Skip over the 'MThd' magic number. */ + offset.QuadPart = 4; + hr = IStream_Seek(stream, offset, STREAM_SEEK_SET, NULL); + if (FAILED(hr)) + return hr; + I'd suggest adopting the very common Wine pattern for such error handling, which will save a lot of vertical space for otherwise very uninteresting and very unlikely error cases:
```suggestion:-3+0 if (FAILED(hr = IStream_Seek(stream, offset, STREAM_SEEK_SET, NULL))) return hr; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4982#note_59643