Re: [PATCH v4 0/2] MR5178: winewayland.drv: set wayland app-id from the process name

[Alexandros Frantzis (＠afrantzis)]

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_surface.c:
> if (damage) NtGdiDeleteObjectApp(damage);
>  }
> +
> +/**********************************************************************
> + *          wayland_surface_set_title
> + */
> +void wayland_surface_set_title(struct wayland_surface *surface, LPCWSTR text)
> +{
> +    DWORD text_len;
> +    DWORD utf8_count;
> +    char *utf8 = NULL;
> +
> +    if (!surface->xdg_toplevel)

Let's change this to `assert(surface->xdg_toplevel)`, i.e., make it a precondition that this function should only be called on a toplevel surfaces, since that's the only kind for which a title is relevant.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_63085