17 Oct
2022
17 Oct
'22
10:54 a.m.
Giovanni Mascellani (@giomasce) commented about tests/shader_runner.c:
runner->is_todo = false;
if (match_string(line, "todo", &line)) runner->is_todo = true;
- if (match_string(line, "draw quad", &line)) + if (match_string(line, "dispatch", &line)) + { + unsigned int x, y, z; + + ret = sscanf(line, "%u %u %u", &x, &y, &z); + if (ret < 3) + fatal_error("Malformed dispatch arguments '%s'.\n", line); + + runner->last_render_failed = !runner->ops->dispatch(runner, x, y, z);
This segfaults if somebody tries to run a compute shader on D3D9. Maybe we would like to error out properly instead? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/30#note_10936