On Sat Mar 8 23:54:10 2025 +0000, Matteo Bruni wrote:
FWIW, I added one more test here before reading further (test 6 basically covers the same): ```suggestion:-4+0 { "_2", 0, 8, { .f = { 1.0f, 2.0f } }, { .f = { 1.0f, 0.0f } }, .todo_hr = TRUE }, { "_2", 0, 20, { .f = { 1.0f, 2.0f, 0.0f, 0.0f, 3.0f } }, { .f = { 1.0f, 3.0f, 0.0f, 0.0f, 0.0f } }, .todo_hr = TRUE }, ``` I also changed the code below to have the `memcmp()` go for `param_desc.Rows * 4 * param_desc.Elements` DWORDs and cleared `tmp` before each iteration. I don't think adding this test is particularly necessary, or even a good idea. Same WRT changing the inner `for` loop end condition. I'll come back to the other change below. I added the test you've posted above, not sure if that's what you wanted or not :D I can remove it if need be.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7505#note_97284